Fix my Flawed Trigger :D

This is my current trigger works ok, but for somereason some items never drop. I need to find a way to make all my items in my first trigger into 1 variable

Make a trigger that runs at map init
In that trigger put:
Set ItemType[1] = Sword of Judgment
Set ItemType[2] = Potion of Mana
Set ItemType[3] = Potion of Healing
Set ItemType[4] = Robe of Icarus
Set ItemType[5] = |||||||||||||||||
Set ItemType[6] = |||||||||||||
Set ItemType[7] = |||||||||||||||

And so on for all your items

Then in the Drop item trigger
Have it like:
Set Integer = Random Integer number between (1 and 100)
Set RandItem = Random Integer number between (1 and 7)
If Integer Less then Or Equal to 5
Then
Item- Create ItemType[RandItem] at position of Dying Unit



7 would be the number of items that could drop
The maximum number in the ItemType array

so arrays are a bit confusing and i think you're a bit confused on em

an array is like a group of individual variables
so imagine you have these variables item1, item2, item3 and they each have their own item
item1 = mana pot
item2 = health pot
item 3 = boots of speed

equivalently you could make an array called item
so
item[1] = mana pot
item[2] = health pot
item[3] = boots of speed

now instead of having 3 separate variables you have one array which stores everything
at first glance there's no difference between the two, but using arrays lets you do other things much easier (like the trigger youre trying to make)

more on arrays:

so in your trigger your setting one element of 1 array to be a bunch of different things

what happens is
ItemType[1] = sword of judgement
and then 3 seconds later
ItemType[1] = Potion of Mana
and then 3 seconds later its something else

in effect the array only stores one variable instead of all the variables
what it should be is:
ItemType[1] = ...
ItemType[2] = ...
etc
(you also don't need the wait times)



here's how i would do your trigger
first off fix storing your items in the array

then in the 2nd screen shot you posted

set Integer = [Random integer number between 1 and <the total number of items in your array>]
Item - Create ItemType[Integer] at (Position of (Dying Unit))

that's literally all you'll have to do

Yeah, listen to serens explanation of arrays

Your trigger confused me at first with what you were tyring to do because of the way you used arrays, just rewriting the same thing over and over again, i was thinking why does he even have an array for this
And with the backwards way you were getting a random item, a way that no sane programmer would come up with, i thought you werent actually trying to get a random item

im a sick man what can i say pat (i was laughing out loud while readin your post)

Ty for the help guys (especially for explaining integers, msot of the time i have no idea what im doing)

But also for your triggers, it seems that it has 100% to drop an item and i want it to be only 5%, or maybe it isnt 100% and my inept triggering skills wont allow me to see it.

I was aware though that each integer was overwriting the previous, and since i didn't know how to make them all fit into 1 i made that every 3 seconds only 1 type of item can drop, and every 6 second only another type of item could drop. This was the only way i could make this weird trigger work.

And how i came up with this mess of a trigger is that i looked up a buncha item drop triggers and one of them made that it always dropped an item and the other made that it rarely dropped an item, but it was only the same item over and over. So i mashed them together and threw in some of my own triggering. It quite beautiful isnt it... MUHUAHAHAHAHHAHA